Skip to content

Commit 885ace0

Browse files
committed
[KYUUBI #1769][FOLLOWUP] Some cleanups for log4j properties
<!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html 2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'. 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'. --> ### _Why are the changes needed?_ <!-- Please clarify why the changes are needed. For instance, 1. If you add a feature, you can talk about the use case of it. 2. If you fix a bug, you can clarify why it is a bug. --> This is a followup of #1769. Cleanup the log4j properties files and using log4j2.properties for UT. ### _How was this patch tested?_ Passed UT. Closes #1842 from turboFei/remove_log4j1. Closes #1769 b675755 [Fei Wang] unused change 365fbec [Fei Wang] revert license 14c64ec [Fei Wang] exclude log4j 1.2.17 in slf4j-log4j12 034b04d [Fei Wang] recover jcl-over-slf4j and slf4j-api for k8s it 2beae75 [Fei Wang] remove log4j 1.2.17 b00f07b [Fei Wang] remove from license e55fd2e [Fei Wang] remove unused dependencies ab86f02 [Fei Wang] [KYUUBI #1769][FOLLOWUP] Some cleanups for log4j properties Authored-by: Fei Wang <fwang12@ebay.com> Signed-off-by: Fei Wang <fwang12@ebay.com>
1 parent 65d50e2 commit 885ace0

File tree

20 files changed

+13
-638
lines changed

20 files changed

+13
-638
lines changed

LICENSE-binary

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,6 @@ org.apache.thrift:libfb303
247247
org.apache.thrift:libthrift
248248
org.webjars:swagger-ui
249249
org.yaml:snakeyaml
250-
log4j:log4j
251250
io.dropwizard.metrics:metrics-core
252251
io.dropwizard.metrics:metrics-jmx
253252
io.dropwizard.metrics:metrics-json

conf/log4j.properties.template

Lines changed: 0 additions & 33 deletions
This file was deleted.

dev/dependencyList

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ log4j-1.2-api/2.17.1//log4j-1.2-api-2.17.1.jar
7676
log4j-api/2.17.1//log4j-api-2.17.1.jar
7777
log4j-core/2.17.1//log4j-core-2.17.1.jar
7878
log4j-slf4j-impl/2.17.1//log4j-slf4j-impl-2.17.1.jar
79-
log4j/1.2.17//log4j-1.2.17.jar
8079
metrics-core/4.1.1//metrics-core-4.1.1.jar
8180
metrics-jmx/4.1.1//metrics-jmx-4.1.1.jar
8281
metrics-json/4.1.1//metrics-json-4.1.1.jar

dev/kyuubi-extension-spark-3-1/src/test/resources/log4j.properties

Lines changed: 0 additions & 44 deletions
This file was deleted.

dev/kyuubi-extension-spark-3-2/src/test/resources/log4j.properties

Lines changed: 0 additions & 44 deletions
This file was deleted.

dev/kyuubi-extension-spark-common/src/test/resources/log4j.properties

Lines changed: 0 additions & 44 deletions
This file was deleted.

dev/kyuubi-tpcds/pom.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,12 +53,6 @@
5353
<groupId>commons-io</groupId>
5454
<artifactId>commons-io</artifactId>
5555
</dependency>
56-
57-
<dependency>
58-
<groupId>org.slf4j</groupId>
59-
<artifactId>slf4j-api</artifactId>
60-
<scope>provided</scope>
61-
</dependency>
6256
</dependencies>
6357

6458
<build>

externals/kyuubi-flink-sql-engine/src/test/resources/log4j.properties

Lines changed: 0 additions & 44 deletions
This file was deleted.

externals/kyuubi-spark-sql-engine/src/test/resources/log4j.properties

Lines changed: 0 additions & 44 deletions
This file was deleted.

externals/kyuubi-trino-engine/src/test/resources/log4j.properties

Lines changed: 0 additions & 44 deletions
This file was deleted.

0 commit comments

Comments
 (0)