Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Remove default settings spark.sql.execution.topKSortFallbackThreshold #5005

Closed
2 of 4 tasks
cxzl25 opened this issue Jun 29, 2023 · 1 comment
Closed
2 of 4 tasks

[Bug] Remove default settings spark.sql.execution.topKSortFallbackThreshold #5005

cxzl25 opened this issue Jun 29, 2023 · 1 comment
Assignees
@QianyongY
Labels
kind:bug This is a clearly a bug priority:major

Comments

@cxzl25
Copy link
Contributor

cxzl25 commented Jun 29, 2023 •
edited
Loading

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

The query results may be inaccurate.

Setting the topKSortFallbackThreshold value may lead to inaccurate results
https://issues.apache.org/jira/browse/SPARK-44240

#1018

Affects Version(s)

master/1.7/1.6/1.5

Kyuubi Server Log Output

No response

Kyuubi Engine Log Output

No response

Kyuubi Server Configurations

No response

Kyuubi Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to fix.
  • No. I cannot submit a PR at this time.
@cxzl25 cxzl25 added kind:bug This is a clearly a bug priority:major labels Jun 29, 2023
@QianyongY
Copy link
Contributor

please assgin to me

QianyongY added a commit to QianyongY/incubator-kyuubi that referenced this issue Jun 29, 2023
@QianyongY
[KYUUBI apache#5005] Remove default settings
3bc8b74
@QianyongY QianyongY mentioned this issue Jun 29, 2023
Closed
3 tasks
turboFei pushed a commit that referenced this issue Jun 30, 2023
@QianyongY @turboFei
[KYUUBI #5005] Remove default settings `spark.sql.execution.topKSortF…
ed0e68c 
…allbackThreshold`

### _Why are the changes needed?_
close #5005

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

Closes #5006 from QianyongY/features/kyuubi-5005.

Closes #5005

3bc8b74 [yongqian] [KYUUBI #5005] Remove default settings

Authored-by: yongqian <yongqian@trip.com>
Signed-off-by: fwang12 <fwang12@ebay.com>
(cherry picked from commit dddaeaa)
Signed-off-by: fwang12 <fwang12@ebay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QianyongY QianyongY

Labels
kind:bug This is a clearly a bug priority:major
Projects
None yet
Milestone
No milestone
2 participants
@cxzl25 @QianyongY