Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Separate closed and online sessions[statements] in the SparkUI's engine tab #5894

Closed
3 of 4 tasks
beryllw opened this issue Dec 21, 2023 · 0 comments
Closed
3 of 4 tasks

[Improvement] Separate closed and online sessions[statements] in the SparkUI's engine tab #5894

beryllw opened this issue Dec 21, 2023 · 0 comments

Comments

@beryllw
Copy link
Contributor

beryllw commented Dec 21, 2023 •
edited
Loading

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

SparkUI's engine tab

How should we improve?

Currently, closed and online sessions are grouped together, which is not convenient. We can improve this by showing closed sessions[statements] in a separate group.
image
like spark
image

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
  • No. I cannot submit a PR at this time.
@beryllw beryllw changed the title [Improvement]Group closed and online sessions[statements] in the SparkUI's engine tab [Improvement] Separate closed and online sessions[statements] in the SparkUI's engine tab Dec 21, 2023
beryllw pushed a commit to beryllw/incubator-kyuubi that referenced this issue Dec 22, 2023
[kyuubi apache#5894]Separate closed and online sessions[statements] i…
02e518d 
…n the SparkUI's engine tab
beryllw pushed a commit to beryllw/incubator-kyuubi that referenced this issue Jan 2, 2024
[KYUUBI apache#5894] fix
a0e97cd
beryllw pushed a commit to beryllw/incubator-kyuubi that referenced this issue Jan 4, 2024
[KYUUBI apache#5894] Separate closed and online sessions[statements] …
4aa44af 
…in the SparkUI's engine tab
beryllw pushed a commit to beryllw/incubator-kyuubi that referenced this issue Jan 4, 2024
[KYUUBI apache#5894] Separate closed and online sessions[statements] …
83c7b15 
…in the SparkUI's engine tab
@beryllw beryllw mentioned this issue Jan 4, 2024
Closed
4 tasks
beryllw pushed a commit to beryllw/incubator-kyuubi that referenced this issue Jan 4, 2024
[KYUUBI apache#5894] fix scalastyle check
3a0e370
zhaohehuhu pushed a commit to zhaohehuhu/incubator-kyuubi that referenced this issue Feb 5, 2024
@zhaohehuhu
[KYUUBI apache#5894] Separate closed and online sessions/statements i…
10e2d7e 
…n the SparkUI's engine tab

Separate closed and online sessions[statements] in the SparkUI's engine tab

# 🔍 Description
## Issue References 🔗

This pull request fixes apache#5894

## Describe Your Solution 🔧
Separate closed and online sessions[statements] in the SparkUI's engine tab
![image](https://github.com/apache/kyuubi/assets/25627922/b39f9215-f629-4c5d-ac3d-9d7c4a8ebff0)

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

unit test will add soon.

---

# Checklist 📝

- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#5946 from Kwafoor/kyuubi_5894.

Closes apache#5894

ade3fc1 [wangjunbo] fix
d71a61a [wangjunbo] rename span id
0b600f5 [wangjunbo] rename span id
f56ca7e [wangjunbo] fix code
79b8e33 [wangjunbo] delete test code
cd3ecac [wangjunbo] fix CI test, fix html document id duplicate
3a0e370 [wangjunbo] [KYUUBI apache#5894] fix scalastyle check
83c7b15 [wangjunbo] [KYUUBI apache#5894] Separate closed and online sessions[statements] in the SparkUI's engine tab

Authored-by: wangjunbo <wangjunbo@qiyi.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
zhaohehuhu pushed a commit to zhaohehuhu/incubator-kyuubi that referenced this issue Mar 21, 2024
@zhaohehuhu
[KYUUBI apache#5894] Separate closed and online sessions/statements i…
75c1c07 
…n the SparkUI's engine tab

Separate closed and online sessions[statements] in the SparkUI's engine tab

# 🔍 Description
## Issue References 🔗

This pull request fixes apache#5894

## Describe Your Solution 🔧
Separate closed and online sessions[statements] in the SparkUI's engine tab
![image](https://github.com/apache/kyuubi/assets/25627922/b39f9215-f629-4c5d-ac3d-9d7c4a8ebff0)

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

unit test will add soon.

---

# Checklist 📝

- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#5946 from Kwafoor/kyuubi_5894.

Closes apache#5894

ade3fc1 [wangjunbo] fix
d71a61a [wangjunbo] rename span id
0b600f5 [wangjunbo] rename span id
f56ca7e [wangjunbo] fix code
79b8e33 [wangjunbo] delete test code
cd3ecac [wangjunbo] fix CI test, fix html document id duplicate
3a0e370 [wangjunbo] [KYUUBI apache#5894] fix scalastyle check
83c7b15 [wangjunbo] [KYUUBI apache#5894] Separate closed and online sessions[statements] in the SparkUI's engine tab

Authored-by: wangjunbo <wangjunbo@qiyi.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@beryllw