[KYUUBI #728] Support SQL State: 0A000 - feature_not_supported #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #729 +/- ##
=======================================
Coverage 80.49% 80.50%
=======================================
Files 122 122
Lines 4748 4749 +1
Branches 576 576
=======================================
+ Hits 3822 3823 +1
Misses 605 605
Partials 321 321
Continue to review full report at Codecov.
|
|
we shall call this at FrontendService for unsupported features |
ulysses-you
changed the title
turboFei
reviewed
Jul 4, 2021
| @@ -81,6 +81,10 @@ object KyuubiSQLException { | |||
| } | |||
| } | |||
|
|
|||
| def featureNotSupported(): KyuubiSQLException = { | |||
| KyuubiSQLException("feature not supported", sqlState = "0A000") | |||
| } | |||
There was a problem hiding this comment.
could you invoke it in the FrontendService for unsupported operation?
yaooqinn
approved these changes
Jul 5, 2021
|
thanks, merging to master for v1.3.0 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Follow #670 to:
Apply errorCode 0A000: feature_not_supported to val errStatus = KyuubiSQLException("Feature is not @available").toTStatus
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request