-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce JDBC parameters to control connection timeout #3152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3152 +/- ##
============================================
- Coverage 51.44% 51.37% -0.08%
Complexity 6 6
============================================
Files 456 456
Lines 25328 25336 +8
Branches 3520 3520
============================================
- Hits 13031 13016 -15
- Misses 11055 11070 +15
- Partials 1242 1250 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. |
pan3793
changed the title
[WIP] Introduce JDBC parameters to control connection timeout
Introduce JDBC parameters to control connection timeout
Jul 27, 2022
cxzl25
reviewed
Jul 27, 2022
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiConnection.java
Outdated
Show resolved
Hide resolved
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiConnection.java
Show resolved
Hide resolved
cxzl25
approved these changes
Jul 29, 2022
Thanks, merging to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
There are two concepts
connect timeout
andso timeout
in the socket, currently, the Kyuubi Hive JDBC driver usesDriverManager#loginTimeout
as both of them, it does not make sense, and will cause unexpected "read timeout" exceptions ifDriverManager#loginTimeout
was set a small value, e.g. Spring Boot set it to 30s in default.This PR proposes to introduce two dedicated JDBC parameters to control them.
See also apache/hive#3379
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request