Detected Dependency List Change for better dependency management #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Scan Summary
| Tool | Critical | High | Medium | Low | Status |
|---|---|---|---|---|---|
| Dependency Scan (java) | 0 | 1 | 3 | 0 | ✅ |
| Security Audit for Infrastructure | 0 | 0 | 0 | 0 | ✅ |
| Java Source Analyzer | 0 | 0 | 0 | 1 | ✅ |
| Class File Analyzer | 0 | 6 | 0 | 0 | ❌ |
| Python Security Analysis | 3 | 0 | 0 | 0 | ❌ |
| Python Source Analyzer | 0 | 0 | 0 | 0 | ✅ |
| Scala Security Audit | 0 | 6 | 0 | 0 | ❌ |
| Shell Script Analysis | 0 | 0 | 0 | 0 | ✅ |
Recommendation
Please review the findings from Code scanning alerts before approving this pull request. You can also configure the build rules or add suppressions to customize this bot 👍
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
==========================================
+ Coverage 80.65% 80.67% +0.02%
==========================================
Files 101 101
Lines 3706 3706
Branches 452 452
==========================================
+ Hits 2989 2990 +1
Misses 483 483
+ Partials 234 233 -1
Continue to review full report at Codecov.
|
|
cc @pan3793 @ulysses-you please take a look |
|
It's pretty good! And I think we also need to update document to tell contributors what they should do when change dependencies. |
|
good point~ Let me update the doc |
pan3793
approved these changes
Mar 11, 2021
|
thanks, merged to master for v1.2.0 |
yangrong688
pushed a commit
to yangrong688/kyuubi
that referenced
this pull request
Mar 13, 2021
…ency management  [](https://github.com/yaooqinn/kyuubi/pull/416)     [❨?❩](https://pullrequestbadge.com/?utm_medium=github&utm_source=yaooqinn&utm_campaign=badge_info)<!-- PR-BADGE: PLEASE DO NOT REMOVE THIS COMMENT --> <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html 2. If the PR is related to an issue in https://github.com/yaooqinn/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'. 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'. --> ### _Why are the changes needed?_ <!-- Please clarify why the changes are needed. For instance, 1. If you add a feature, you can talk about the use case of it. 2. If you fix a bug, you can clarify why it is a bug. --> Detect Dependency List Change, to let us and users know what actually release with Kyuubi ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests) locally before make a pull request Closes apache#416 from yaooqinn/dep. 5938423 [Kent Yao] update doc 037c897 [Kent Yao] nit 2b06bf9 [Kent Yao] Detected Dependency List Change for better dependency management Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Detect Dependency List Change, to let us and users know what actually release with Kyuubi
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request