Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #4338] Bump Spark from 3.3.1 to 3.3.2 #4339

Closed
wants to merge 1 commit into from

Conversation

a49a
Copy link
Contributor

@a49a a49a commented Feb 16, 2023

Why are the changes needed?

close #4338 .

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@bowenliang123
Copy link
Contributor

Updated the description as close #4338 . to make sure it's properly linked to the issue.
image

@yaooqinn
Copy link
Member

Hi @bowenliang123, that is not necessary if PR has a proper title-prefix

@bowenliang123
Copy link
Contributor

Hi @bowenliang123, that is not necessary if PR has a proper title-prefix

Got that.

@bowenliang123
Copy link
Contributor

@a49a Rebase to master branch with #4340 merged, to fix docs building error (https://github.com/apache/kyuubi/actions/runs/4191677087/jobs/7266357199#step:4:95).

@a49a
Copy link
Contributor Author

a49a commented Feb 16, 2023

@bowenliang123 I have rebased the master branch. Thank you for your review.

@pan3793
Copy link
Member

pan3793 commented Feb 16, 2023

Some Hive Connector tests failed, cc @yikf

@yikf
Copy link
Contributor

yikf commented Feb 17, 2023

The root cause looks like is FileWriterFactory#jobId is not serializable, It was introduced in apache/spark#38980, will take a look.

@pan3793 pan3793 added this to the v1.7.0 milestone Feb 18, 2023
@pan3793
Copy link
Member

pan3793 commented Feb 18, 2023

The failure is resolved by #4359, merged to master/1.7

@pan3793 pan3793 closed this in 9aebeb8 Feb 18, 2023
pan3793 pushed a commit that referenced this pull request Feb 18, 2023
### _Why are the changes needed?_

close #4338 .

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #4339 from a49a/bump-spark332.

Closes #4338

6c741d8 [Luning Wang] [KYUUBI #4338] Bump Spark from 3.3.1 to 3.3.2

Authored-by: Luning Wang <wang4luning@gmail.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit 9aebeb8)
Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Spark from 3.3.1 to 3.3.2
5 participants