Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactor JDBCMetadataStore #5081

Closed
wants to merge 1 commit into from
Closed

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Jul 21, 2023

Why are the changes needed?

This is a pure code refactor extracted from #4790 to reduce the diff.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2023

Codecov Report

Merging #5081 (537d623) into master (7631e7d) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff           @@
##           master   #5081   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         564     564           
  Lines       31311   31313    +2     
  Branches     4098    4097    -1     
======================================
- Misses      31311   31313    +2     
Impacted Files Coverage Δ
...yuubi/server/metadata/jdbc/JDBCMetadataStore.scala 0.00% <0.00%> (ø)
...ubi/server/metadata/jdbc/JdbcDatabaseDialect.scala 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pan3793 pan3793 self-assigned this Jul 21, 2023
@pan3793 pan3793 added this to the v1.8.0 milestone Jul 21, 2023
@pan3793
Copy link
Member Author

pan3793 commented Jul 21, 2023

Thanks, merged to master

@pan3793 pan3793 closed this in bf03075 Jul 21, 2023
@pan3793 pan3793 deleted the dialect branch July 21, 2023 12:32
link3280 pushed a commit to link3280/kyuubi that referenced this pull request Jul 23, 2023
### _Why are the changes needed?_

This is a pure code refactor extracted from apache#4790 to reduce the diff.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

Closes apache#5081 from pan3793/dialect.

Closes apache#5081

537d623 [Cheng Pan] Minor refactor JDBCMetadataStore

Authored-by: Cheng Pan <chengpan@apache.org>
Signed-off-by: Cheng Pan <chengpan@apache.org>
zhaohehuhu pushed a commit to zhaohehuhu/incubator-kyuubi that referenced this pull request Jul 24, 2023
### _Why are the changes needed?_

This is a pure code refactor extracted from apache#4790 to reduce the diff.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

Closes apache#5081 from pan3793/dialect.

Closes apache#5081

537d623 [Cheng Pan] Minor refactor JDBCMetadataStore

Authored-by: Cheng Pan <chengpan@apache.org>
Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants