[Minor] Fix unpaired quote in message pattern #5100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaooqinn
approved these changes
Jul 27, 2023
|
PS: This issue is scanned and reported by Qodana on local IDEA 2023.2. |
|
The oracle docs you linked seem invalid. |
pan3793
approved these changes
Jul 27, 2023
Oops. Updated with a correct link. |
bowenliang123
added a commit
that referenced
this pull request
Jul 27, 2023
### _Why are the changes needed?_ - Remove the existing single quote in message format which causes the argument 0 is not used - `A single quote itself must be represented by doubled single quotes '' throughout a String.` https://docs.oracle.com/javase/8/docs/api/java/text/MessageFormat.html ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request Closes #5100 from bowenliang123/datatype-msg. Closes #5100 8135ff1 [liangbowen] fix Authored-by: liangbowen <liangbowen@gf.com.cn> Signed-off-by: liangbowen <liangbowen@gf.com.cn> (cherry picked from commit 25e1a16) Signed-off-by: liangbowen <liangbowen@gf.com.cn>
|
Thanks, merged to master(1.8.0) and 1.7.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
A single quote itself must be represented by doubled single quotes '' throughout a String.https://docs.oracle.com/javase/8/docs/api/java/text/MessageFormat.htmlHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request