Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TPCDS query output schema check #566

Merged
merged 10 commits into from
Apr 22, 2021
Merged

Add TPCDS query output schema check #566

merged 10 commits into from
Apr 22, 2021

Conversation

ulysses-you
Copy link
Contributor

@ulysses-you ulysses-you commented Apr 22, 2021

Why are the changes needed?

Use TPCDS query to check if we have some behavior change.

Note that

  1. this PR only add q1.
  2. this PR just to check the output schema. The output data check can be added in future.
  3. this new added test file structure looks like
tpcds-1_4
  - q1
    - q1.sql
    - q1.output.schema 
    - q1.output.data (if we support this in future)
  - q2
  ......

How was this patch tested?

Add new test

super.afterAll()
}

private val regenerateGoldenFiles = sys.env.get("KYUUBI_GENERATE_GOLDEN_FILES").contains("1")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can reuse KYUUBI_UPDATE here, it's much shorter

@yaooqinn yaooqinn added the Test label Apr 22, 2021
@yaooqinn yaooqinn added this to the v1.2.0 milestone Apr 22, 2021
@yaooqinn
Copy link
Member

Great work, this is a huge step!

@ulysses-you
Copy link
Contributor Author

Travis passed.

The GA failure is not related

Error:  ## Exception when compiling 13 sources to /home/runner/work/kyuubi/kyuubi/externals/kyuubi-spark-sql-engine/target/scala-2.12/test-classes

@yaooqinn yaooqinn closed this Apr 22, 2021
@yaooqinn yaooqinn reopened this Apr 22, 2021
Copy link
Member

@turboFei turboFei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@turboFei
Copy link
Member

Error:  Failed to execute goal net.alchim31.maven:scala-maven-plugin:4.3.0:testCompile (scala-test-compile-first) on project kyuubi-spark-sql-engine: wrap: scala.reflect.internal.FatalError: Error accessing /home/runner/.m2/repository/org/apache/hive/hive-llap-common/2.3.7/hive-llap-common-2.3.7.jar: error in opening zip file -> [Help 1]

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2021

Codecov Report

Merging #566 (edff47d) into master (29e169b) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head edff47d differs from pull request most recent head 1d35189. Consider uploading reports for the commit 1d35189 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
+ Coverage   79.75%   79.79%   +0.04%     
==========================================
  Files         118      118              
  Lines        4524     4524              
  Branches      547      547              
==========================================
+ Hits         3608     3610       +2     
+ Misses        610      608       -2     
  Partials      306      306              
Impacted Files Coverage Δ
...org/apache/kyuubi/operation/ExecuteStatement.scala 81.48% <0.00%> (+2.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29e169b...1d35189. Read the comment docs.

@turboFei
Copy link
Member

thanks, merging to master

@turboFei
Copy link
Member

seems there is some issue for reopened a pr.

I will use github merge function to merge it.

Thanks
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants