-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TPCDS query output schema check #566
Conversation
super.afterAll() | ||
} | ||
|
||
private val regenerateGoldenFiles = sys.env.get("KYUUBI_GENERATE_GOLDEN_FILES").contains("1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can reuse KYUUBI_UPDATE here, it's much shorter
Great work, this is a huge step! |
Travis passed. The GA failure is not related
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
|
Codecov Report
@@ Coverage Diff @@
## master #566 +/- ##
==========================================
+ Coverage 79.75% 79.79% +0.04%
==========================================
Files 118 118
Lines 4524 4524
Branches 547 547
==========================================
+ Hits 3608 3610 +2
+ Misses 610 608 -2
Partials 306 306
Continue to review full report at Codecov.
|
thanks, merging to master |
Why are the changes needed?
Use TPCDS query to check if we have some behavior change.
Note that
q1
.How was this patch tested?
Add new test