[KYUUBI #6211] Check memory offHeap enabled for CustomResourceProfileExec #6211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6211 +/- ##
============================================
- Coverage 58.40% 58.39% -0.01%
Complexity 24 24
============================================
Files 651 651
Lines 39499 39499
Branches 5430 5430
============================================
- Hits 23069 23067 -2
+ Misses 13956 13954 -2
- Partials 2474 2478 +4 ☔ View full report in Codecov by Sentry. |
wForget
changed the title
wForget
added a commit
that referenced
this pull request
Mar 28, 2024
…Exec # 🔍 Description ## Issue References 🔗 This pull request fixes # ## Describe Your Solution 🔧 We should check `spark.memory.offHeap.enabled` when applying for `executorOffHeapMemory`. ## Types of changes 🔖 - [X] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [X] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6211 from wForget/hotfix. Closes #6211 1c7c8cd [wforget] Check memory offHeap enabled for CustomResourceProfileExec Authored-by: wforget <643348094@qq.com> Signed-off-by: wforget <643348094@qq.com> (cherry picked from commit 9114e50) Signed-off-by: wforget <643348094@qq.com>
|
thanks, merged to master and 1.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This pull request fixes #
Describe Your Solution 🔧
We should check
spark.memory.offHeap.enabledwhen applying forexecutorOffHeapMemory.Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.