[KYUUBI #6252] Upgrade hive-service-rpc 4.0.0 #6262
Conversation
pan3793
changed the title
| @@ -594,6 +594,45 @@ abstract class TFrontendService(name: String) | |||
| resp | |||
| } | |||
|
|
|||
| override def UploadData(req: TUploadDataReq): TUploadDataResp = { | |||
| val resp = new TUploadDataResp() | |||
There was a problem hiding this comment.
the Kyuubi's implementation is not fully same as Hive, let's throw UnsupportedOperationException here directly, then we don't need to modify other classes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6262 +/- ##
============================================
- Coverage 58.48% 58.39% -0.09%
Complexity 24 24
============================================
Files 651 651
Lines 39513 39515 +2
Branches 5441 5441
============================================
- Hits 23109 23075 -34
- Misses 13937 13964 +27
- Partials 2467 2476 +9 ☔ View full report in Codecov by Sentry. |
…method in TFrontendService
|
LGTM if CI passed |
| } | ||
|
|
||
| override def DownloadData(req: TDownloadDataReq): TDownloadDataResp = { | ||
| throw new UnsupportedOperationException("Method DownloadData has not been implemented.") |
There was a problem hiding this comment.
Use KyuubiSQLException.featureNotSupported?
There was a problem hiding this comment.
OK. But I see UnsupportedOperationException is used by many places. Should I replace them all or just for here?
There was a problem hiding this comment.
On second thought, we can use TDownloadDataResp with the error status directly, just like CancelDelegationToken
There was a problem hiding this comment.
@zhaohehuhu let's narrow the scope to the newly introduced API. "error status" idea SGTM.
There was a problem hiding this comment.
On second thought, we can use TDownloadDataResp with the error status directly, just like CancelDelegationToken
this approach is not applicable, because the resp has no status field, thus we can not mark the response as failed
pom.xml
Outdated
| <enabled>false</enabled> | ||
| </snapshots> | ||
| <id>kyuubi-shaded-staging-0.4.0-rc0</id> | ||
| <url>https://repository.apache.org/content/repositories/orgapachekyuubi-1045</url> |
There was a problem hiding this comment.
I just finished the release of Kyuubi Shaded 0.4.0, Jar will be available on Maven Central soon, the staging repo could be removed now.
# 🔍 Description ## Issue References 🔗 close #6252 ## Describe Your Solution 🔧 Upgrade hive-service-rpc 4.0.0 ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 Pass existing tests --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6262 from zhaohehuhu/dev-0407. Closes #6252 d7df86d [Cheng Pan] address comments 9bdf04e [hezhao2] delete code fd7b231 [hezhao2] delete code d524687 [hezhao2] reformat 88c0044 [hezhao2] throws UnsupportedOperationException for UploadData and DownloadData method in TFrontendService 62c5b89 [Cheng Pan] Update pom.xml 1ac087c [Cheng Pan] Update pom.xml 78bca3a [hezhao2] Upgrade hive-service-rpc 4.0.0 Lead-authored-by: hezhao2 <hezhao2@cisco.com> Co-authored-by: Cheng Pan <pan3793@gmail.com> Co-authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit b9c97dd) Signed-off-by: Cheng Pan <chengpan@apache.org>
|
Merged to master/1.9. Also cc @slfan1989 |
🔍 Description
Issue References 🔗
close #6252
Describe Your Solution 🔧
Upgrade hive-service-rpc 4.0.0
Types of changes 🔖
Test Plan 🧪
Pass existing tests
Checklist 📝
Be nice. Be informative.