Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #6447] Use static regex Pattern instances in JavaUtils.timeStringAs and JavaUtils.byteStringAs #6448

Closed
wants to merge 1 commit into from

Conversation

lsm1
Copy link
Contributor

@lsm1 lsm1 commented Jun 4, 2024

🔍 Description

Issue References 🔗

This pull request fixes #6447

Describe Your Solution 🔧

Use static regex Pattern instances in JavaUtils.timeStringAs and JavaUtils.byteStringAs

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.44%. Comparing base (4d58b96) to head (4cc2763).
Report is 2 commits behind head on master.

Current head 4cc2763 differs from pull request most recent head 467066c

Please upload reports for the commit 467066c to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6448      +/-   ##
============================================
+ Coverage     58.33%   58.44%   +0.11%     
  Complexity       24       24              
============================================
  Files           656      656              
  Lines         40268    40446     +178     
  Branches       5498     5541      +43     
============================================
+ Hits          23490    23640     +150     
- Misses        14275    14300      +25     
- Partials       2503     2506       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cxzl25 cxzl25 added this to the v1.10.0 milestone Jun 4, 2024
@pan3793 pan3793 closed this in bb92128 Jun 5, 2024
@pan3793
Copy link
Member

pan3793 commented Jun 5, 2024

Thanks, merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK][TRIVIAL] Use static regex Pattern instances in JavaUtils.timeStringAs and JavaUtils.byteStringAs
4 participants