Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Multiple Configuration Files in FileSessionConfAdvisor #6585

Closed
wants to merge 2 commits into from

Conversation

lsm1
Copy link
Contributor

@lsm1 lsm1 commented Aug 5, 2024

🔍 Description

Issue References 🔗

This pull request fixes #

Describe Your Solution 🔧

The current FileSessionConfAdvisor only supports configuring a single file through kyuubi.session.conf.profiler. However, users may need to use multiple configuration files, and the existing setup does not support this. To address this need, we have updated the FileSessionConfAdvisor to support multiple configuration files.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@lsm1 lsm1 self-assigned this Aug 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (063a192) to head (15b6524).
Report is 27 commits behind head on master.

Files Patch % Lines
...apache/kyuubi/session/FileSessionConfAdvisor.scala 0.00% 6 Missing ⚠️
...in/scala/org/apache/kyuubi/config/KyuubiConf.scala 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #6585    +/-   ##
=======================================
  Coverage    0.00%   0.00%            
=======================================
  Files         677     677            
  Lines       41799   42639   +840     
  Branches     5709    5914   +205     
=======================================
- Misses      41799   42639   +840     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wForget wForget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsm1 lsm1 closed this in 72396e7 Aug 12, 2024
@lsm1
Copy link
Contributor Author

lsm1 commented Aug 12, 2024

Merge to master

@cxzl25 cxzl25 added this to the v1.10.0 milestone Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants