Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime support running on different versions of spark #71

Merged
merged 2 commits into from
May 23, 2018
Merged

Conversation

yaooqinn
Copy link
Member

#67 makes kyuubi support original spark release package with specified maven options. for instance, -Pspark-2.2 gives us a kyuubi runnable package twards spark2.2.x.

But still, we need offer a more compatible way to support different versions of Spark at runtime.

Fix version conflict regression in #67

@yaooqinn yaooqinn added this to the v0.2.0 milestone May 22, 2018
@yaooqinn yaooqinn self-assigned this May 22, 2018
@codecov
Copy link

codecov bot commented May 22, 2018

Codecov Report

Merging #71 into master will increase coverage by 3.01%.
The diff coverage is 44.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #71      +/-   ##
===========================================
+ Coverage     24.19%   27.2%   +3.01%     
  Complexity       84      84              
===========================================
  Files            63      64       +1     
  Lines          2625    2823     +198     
  Branches        377     396      +19     
===========================================
+ Hits            635     768     +133     
- Misses         1927    1974      +47     
- Partials         63      81      +18
Impacted Files Coverage Δ Complexity Δ
src/main/scala/org/apache/spark/SparkEnv.scala 66.66% <35.71%> (ø) 0 <0> (?)
.../main/scala/org/apache/spark/KyuubiSparkUtil.scala 87.23% <83.33%> (-0.58%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd09f56...a8591ac. Read the comment docs.

@yaooqinn yaooqinn merged commit 0e6e434 into master May 23, 2018
@yaooqinn yaooqinn deleted the i70 branch May 23, 2018 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant