Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add monitor module #737

Closed
wants to merge 9 commits into from
Closed

add monitor module #737

wants to merge 9 commits into from

Conversation

zhang1002
Copy link
Contributor

This module's feature:

  1. get all SQL's metrics during runtime
  2. monitor the sqlOperation
  3. for auto-configuring

this module's feature:
1. get all SQL's data in runtime
2. monitor the sqlOperation
3. for auto-configuring
@@ -0,0 +1 @@
## for kyuubi-monitor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

## -> #

we can add some simple description in this md. For example:

This module is used to monitor kyuubi which include kyuubi server and kyuubi engine.

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2021

Codecov Report

Merging #737 (7e35f07) into master (84c07a6) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 7e35f07 differs from pull request most recent head 00e80fd. Consider uploading reports for the commit 00e80fd to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #737   +/-   ##
=======================================
  Coverage   80.49%   80.49%           
=======================================
  Files         122      122           
  Lines        4748     4748           
  Branches      576      576           
=======================================
  Hits         3822     3822           
  Misses        605      605           
  Partials      321      321           
Impacted Files Coverage Δ
...uubi/engine/spark/operation/ExecuteStatement.scala 86.15% <100.00%> (+0.21%) ⬆️
...ache/kyuubi/ha/client/EngineServiceDiscovery.scala 53.84% <100.00%> (ø)
...ache/kyuubi/ha/client/KyuubiServiceDiscovery.scala 100.00% <100.00%> (ø)
...org/apache/kyuubi/ha/client/ServiceDiscovery.scala 55.62% <100.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84c07a6...00e80fd. Read the comment docs.

</parent>
<modelVersion>4.0.0</modelVersion>

<artifactId>kyuubi-monitor</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kyuubi-spark-monitor


<artifactId>kyuubi-monitor</artifactId>
<packaging>jar</packaging>
<name>Kyuubi Project Monitor</name>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kyuubi Project Spark Monitor

pom.xml Outdated
@@ -35,6 +35,7 @@
<module>kyuubi-main</module>
<module>kyuubi-metrics</module>
<module>kyuubi-zookeeper</module>
<module>kyuubi-monitor</module>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move up to L37

@@ -28,6 +28,7 @@
<module>dev/kyuubi-codecov</module>
<module>externals/kyuubi-download</module>
<module>externals/kyuubi-spark-sql-engine</module>
<module>externals/kyuubi-spark-monitor</module>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort alphabetically

@pan3793 pan3793 added the kind:feature Feature request label Jul 2, 2021
@pan3793 pan3793 added this to the v1.3.0 milestone Jul 2, 2021
@pan3793 pan3793 closed this in 902b4b1 Jul 2, 2021
@pan3793
Copy link
Member

pan3793 commented Jul 2, 2021

Thanks, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants