Skip to content

Conversation

uty
Copy link
Contributor

@uty uty commented Apr 20, 2017

Add support of next EC2 API methods: ModifyVolume and DescribeVolumesModifications

Description

  • Add support of ModifyVolume and DescribeVolumesModifications EC2 API methods.
  • Fix name of ebs/volumeType extra attribute mapping.

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 87.283% when pulling 2f81890 on Scalr:for-upstream/modify_volume into 1a07215 on apache:trunk.

Modify volume parameters.
A list of valid parameters can be found at https://goo.gl/N0rPEQ

:param Volume: Volume instance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be lower case. It shouldn't matter I don't think

@tonybaloney
Copy link
Contributor

changes look great 👍

@asfgit asfgit merged commit 2f81890 into apache:trunk Apr 21, 2017
asfgit pushed a commit that referenced this pull request Apr 21, 2017
Closes #1036

Signed-off-by: Anthony Shaw <anthonyshaw@apache.org>
asfgit pushed a commit that referenced this pull request Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants