[LIBCLOUD-780] Add Rackspace RDNS support #652
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends on #650 going in first. |
|
Hrm... testing this against the real API there's some issues still. Closing it for now, will reopen when I sort 'em out. |
jimbobhickville
force-pushed
the
rackspace-rdns
branch
from
b7d239b
to
122ffc6
Compare
|
The documented response for listing PTR records is apparently not what is actually returned by the real API. Adjusted the code/tests to match reality. |
New DNS driver methods: * ex_iterate_ptr_records * ex_get_ptr_record * ex_create_ptr_record * ex_update_ptr_record * ex_delete_ptr_record This should cover all of the functionality offered by the Rackspace DNS API in regards to RDNS.
jimbobhickville
force-pushed
the
rackspace-rdns
branch
from
122ffc6
to
8ecd5d2
Compare
| self.connection.set_context({'resource': 'record', 'id': record_id}) | ||
| response = self.connection.request( | ||
| action='/rdns/%s/%s' % (service_name, record_id)).object | ||
| item = next(iter(response['recordsList']['records'])) |
There was a problem hiding this comment.
IIRC, this is only available in python 2.6+
|
#650 is closed. |
|
LGTM 👍 thanks Greg |
asfgit
pushed a commit
that referenced
this pull request
Dec 4, 2015
|
Great, thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New DNS driver methods:
This should cover all of the functionality offered by the Rackspace
DNS API in regards to RDNS.