Improve exception information and add path information #4351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casionone
reviewed
Mar 13, 2023
| public abstract class FileSystem implements Fs { | ||
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(LocalFileSystem.class); |
There was a problem hiding this comment.
Need to modify， please use org.apache.linkis.common.utils.Logging
casionone
reviewed
Mar 13, 2023
| @@ -75,12 +75,14 @@ public String listRoot() throws IOException { | |||
| @Override | |||
| public long getTotalSpace(FsPath dest) throws IOException { | |||
| String path = dest.getPath(); | |||
| LOG.info("getTotalSpace, path:" + path); | |||
There was a problem hiding this comment.
"Get total space with path:"+path
casionone
reviewed
Mar 13, 2023
| return new File(path).getTotalSpace(); | ||
| } | ||
|
|
||
| @Override | ||
| public long getFreeSpace(FsPath dest) throws IOException { | ||
| String path = dest.getPath(); | ||
| LOG.info("getFreeSpace, path:" + path); | ||
| return new File(path).getFreeSpace(); |
There was a problem hiding this comment.
"Get free space with path:"+path
casionone
reviewed
Mar 13, 2023
| @@ -64,6 +65,7 @@ object ResultSetReader { | |||
|
|
|||
| def getTableResultReader(res: String): ResultSetReader[TableMetaData, TableRecord] = { | |||
| val rsFactory = ResultSetFactory.getInstance | |||
| logger.info(s"getTableResultReader, file path:${res}") | |||
There was a problem hiding this comment.
remove, res may not be a file path
There was a problem hiding this comment.
need add log before fs.init(null)
logger.info("Try to init Fs with path:"+ resPath.getPath)
casionone
pushed a commit
to WeDataSphere/linkis
that referenced
this pull request
Mar 22, 2023
Co-authored-by: casionone <casionone@gmail.com>
CharlieYan24
pushed a commit
to CharlieYan24/linkis
that referenced
this pull request
Mar 28, 2023
…rent * dev-1.4.0: support map string value (apache#4409) Improve exception information and add path information (apache#4351) [fix bug] The s3a file cannot be written because FileSystem is closed prematurely (apache#4375) Optimization of upload file interface in FsRestfulApi.java (apache#4357)
CharlieYan24
added a commit
to CharlieYan24/linkis
that referenced
this pull request
Mar 29, 2023
* dev-1.4.0: Improve exception information and add path information (apache#4351) [fix bug] The s3a file cannot be written because FileSystem is closed prematurely (apache#4375) Optimization of upload file interface in FsRestfulApi.java (apache#4357)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Improve exception information and add path information to exception information(异常信息完善以及在异常信息添加路径信息)
Related issues/PRs
Related issues: #4343
Related pr:#4351
Checklist