Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix bug] The s3a file cannot be written because FileSystem is closed prematurely #4375

Merged
merged 1 commit into from
Mar 16, 2023
Merged

[fix bug] The s3a file cannot be written because FileSystem is closed prematurely #4375

merged 1 commit into from
Mar 16, 2023

Conversation

duhanmin
Copy link
Contributor

@duhanmin duhanmin commented Mar 16, 2023 •
edited

The s3a file cannot be written because FileSystem is closed prematurely

    Utils.tryFinally(if (outputStream != null) flush()) {
      closeFs
      if (outputStream != null) {
        IOUtils.closeQuietly(outputStream)
        outputStream = null
      }
    }

Change to

    Utils.tryFinally(if (outputStream != null) flush()) {
      if (outputStream != null) {
        IOUtils.closeQuietly(outputStream)
        outputStream = null
      }
      closeFs
    }

peacewong
peacewong approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit 581ce1e into apache:dev-1.4.0 Mar 16, 2023
CharlieYan24 pushed a commit to CharlieYan24/linkis that referenced this pull request Mar 28, 2023
@yyc35
Merge branch 'dev-1.4.0' into dev-1.4.0-HiveEngineConn-support-concur…
ecdf1c6 
…rent

* dev-1.4.0:
  support map string value (apache#4409)
  Improve exception information and add path information (apache#4351)
  [fix bug] The s3a file cannot be written because FileSystem is closed prematurely (apache#4375)
  Optimization of upload file interface in FsRestfulApi.java (apache#4357)
CharlieYan24 added a commit to CharlieYan24/linkis that referenced this pull request Mar 29, 2023
@CharlieYan24
Merge branch 'dev-1.4.0' into dev-1.4.0-storge-support-oss-filesystem
d118628 
* dev-1.4.0:
  Improve exception information and add path information (apache#4351)
  [fix bug] The s3a file cannot be written because FileSystem is closed prematurely (apache#4375)
  Optimization of upload file interface in FsRestfulApi.java (apache#4357)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peacewong peacewong peacewong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@duhanmin @peacewong