Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization of upload file interface in FsRestfulApi.java #4357

Merged
merged 5 commits into from Mar 14, 2023

Conversation

binbinCheng
Copy link
Contributor

@binbinCheng binbinCheng commented Mar 10, 2023

What is the purpose of the change

Add relevant default attributes to upload file interface optimization in FsRestfulApi.java

This configuration is used in the checkIsUsersDirectory function, which is false by default. If the user does not set it, the function will not be able to perform path verification(checkIsUsersDirectory 函数中用到该配置,该配置默认为false,如果用户不设置,该函数将无法进行路径校验)

image

image

image

@casionone
Copy link
Contributor

Can you add a more detailed reason for doing this?

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit 1d9c9a3 into apache:dev-1.4.0 Mar 14, 2023
CharlieYan24 pushed a commit to CharlieYan24/linkis that referenced this pull request Mar 28, 2023
…rent

* dev-1.4.0:
  support map string value (apache#4409)
  Improve exception information and add path information (apache#4351)
  [fix bug] The s3a file cannot be written because FileSystem is closed prematurely (apache#4375)
  Optimization of upload file interface in FsRestfulApi.java (apache#4357)
CharlieYan24 added a commit to CharlieYan24/linkis that referenced this pull request Mar 29, 2023
* dev-1.4.0:
  Improve exception information and add path information (apache#4351)
  [fix bug] The s3a file cannot be written because FileSystem is closed prematurely (apache#4375)
  Optimization of upload file interface in FsRestfulApi.java (apache#4357)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants