Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Engine type label support map value #4409

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

GuoPhilipse
Copy link
Member

@GuoPhilipse GuoPhilipse commented Mar 24, 2023

What is the purpose of the change

Engine type label should accept stringvalue like "{\"engineType\":\"shell\",\"version\":\"1\"}"
not only support stringvalue like "hive-1.1.0-cdh5.12.0"

Related issues/PRs

Related issues: #4410
Related pr:#4409

Brief change log

  • Engine type label should accept map string value

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

@GuoPhilipse GuoPhilipse reopened this Mar 27, 2023
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit 1e25954 into apache:dev-1.4.0 Mar 27, 2023
7 checks passed
CharlieYan24 pushed a commit to CharlieYan24/linkis that referenced this pull request Mar 28, 2023
…rent

* dev-1.4.0:
  support map string value (apache#4409)
  Improve exception information and add path information (apache#4351)
  [fix bug] The s3a file cannot be written because FileSystem is closed prematurely (apache#4375)
  Optimization of upload file interface in FsRestfulApi.java (apache#4357)
@GuoPhilipse GuoPhilipse deleted the engineTypeLabel branch April 28, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants