Don't fail on insufficient parameters in ParameterFormatter (#2337)
#2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vy
added
bug
ppkarwasz
requested changes
Mar 4, 2024
There was a problem hiding this comment.
Personally I would maintain the current logic that throws exceptions, I would just catch them in the call sites.
I looked in Log4j 2.19.0 how formatting was done. Using the StringFormatterMessageFactory a call to logger.info("Hello %s and %s!", "world") gives:
2024-03-04 11:18:57,550 main ERROR Unable to format msg: Hello %s and %s!
java.util.MissingFormatArgumentException: Format specifier '%s'
Hello %s and %s!
whereas the default factories for a call to logger.info("Hello {} and {}!", "world") give just:
Hello world and {}!
I don't think the behavior of Log4j 2.19.0 is correct. I would expect rather:
2024-03-04 11:18:57,550 main ERROR Unable to format msg: Hello {} and {}!
java.lang.IllegalArgumentException: Found 2 argument placeholders, but only 1 was provided.
Hello {} and {}!
log4j-api-test/src/test/java/org/apache/logging/log4j/message/ParameterFormatterTest.java
Show resolved
Hide resolved
log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java
Outdated
Show resolved
Hide resolved
ppkarwasz
approved these changes
Mar 5, 2024
log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterizedMessage.java
Outdated
Show resolved
Hide resolved
ppkarwasz
approved these changes
Mar 5, 2024
This was referenced Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.