Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to gradle 7.5.1 (excluding launch scripts, which we have customized) #11886

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

dweiss
Copy link
Contributor

@dweiss dweiss commented Oct 28, 2022

Upgrade gradle to 7.5.1. Switch distribution type to 'bin' instead of 'all' (smaller, excludes documentation and examples - these are irrelevant for us and are available online).

gradlew launch scripts are left as they were since we have customized them heavily and they seem to be working fine.

@dweiss dweiss added this to the 9.5.0 milestone Oct 28, 2022
@dweiss dweiss self-assigned this Oct 28, 2022
@dweiss
Copy link
Contributor Author

dweiss commented Oct 28, 2022

I take the liberty of merging this, since it's a trivial change.

@dweiss dweiss merged commit 5c7edd7 into apache:main Oct 28, 2022
@dweiss dweiss deleted the gradle_7_5_1 branch October 28, 2022 06:50
@rmuir
Copy link
Member

rmuir commented Oct 28, 2022

i guess we could allow users to run it with java 18 now

@dweiss
Copy link
Contributor Author

dweiss commented Oct 28, 2022

I haven't had the time to test but it may indeed work out of the box.

hiteshk25 pushed a commit to cowpaths/lucene that referenced this pull request Nov 8, 2022
hiteshk25 pushed a commit to cowpaths/lucene that referenced this pull request Nov 8, 2022
hiteshk25 added a commit to cowpaths/lucene that referenced this pull request Nov 8, 2022
…omized) (apache#11886) (#9)

Co-authored-by: Dawid Weiss <dawid.weiss@carrotsearch.com>
magibney pushed a commit to cowpaths/lucene that referenced this pull request Dec 15, 2022
justinrsweeney pushed a commit to cowpaths/lucene that referenced this pull request Jan 30, 2023
…omized) (apache#11886) (#9)

Co-authored-by: Dawid Weiss <dawid.weiss@carrotsearch.com>
justinrsweeney pushed a commit to cowpaths/lucene that referenced this pull request Jan 30, 2023
…omized) (apache#11886) (#9)

Co-authored-by: Dawid Weiss <dawid.weiss@carrotsearch.com>
justinrsweeney pushed a commit to cowpaths/lucene that referenced this pull request Jan 30, 2023
…omized) (apache#11886) (#9)

Co-authored-by: Dawid Weiss <dawid.weiss@carrotsearch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants