Remove unnecessary NaN checks from LongRange#verifyAndEncode #12008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmuir
approved these changes
Dec 10, 2022
There was a problem hiding this comment.
thanks, really crazy. We may want to investigate other places where we inadvertently do this, by uncommenting this line and setting to WARN and running gradlew check -Dvalidation.errorprone=true. I can't remember how many violations we have across the codebase: https://github.com/apache/lucene/blob/main/gradle/validation/error-prone.gradle#L381
|
I think we should open a followup issue to look into this check. I enabled the check (without your patch) to make sure it finds this bug, and it did, and it also finds other stuff: I think if we really intend to cast a long to a double, we can do it explicitly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor tweak to logic that appears to have been copy/pasted from
DoubleRange.