buildAndPushRelease should optionally pause before assembleRelease #12095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1, this has caught me multiple times! I think I'd personally make it the default but I don't know if others have things set up so that they don't need to type in their GPG pin. |
|
The main reason I didn't make this the default is because I'm not sure whether running this through the releaseWizard would support user input. I'm using the releaseWizard to guide me through the steps but running them all manually, so user input is definitely supported. TBH I'm not sure -- maybe releaseWizard would support user input to subcommands? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildAndPushRelease currently proceeds directly from running tests to assembling the release (and signing jars). Since assembleRelease prompts for GPG key PIN, it can easily happen that the RM steps away while tests are running, and returns to find that tests have completed, but the script has failed due to timing out waiting for GPG pinentry in the
assembleReleasestep. To address this issue, this PR adds a (optional, non-default) pause for user confirmation before proceeding to theassembleReleasephase.