Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce contention in DocumentsWriterPerThreadPool. #12199

Merged
merged 9 commits into from
Mar 15, 2023
Merged

Reduce contention in DocumentsWriterPerThreadPool. #12199

merged 9 commits into from
Mar 15, 2023

Commits on Mar 10, 2023

  1. Reduce contention in DocumentsWriterPerThreadPool. 

    Obtaining a DWPT and putting it back into the pool is subject to contention.
This change reduces contention by using 8 sub pools that are tried sequentially.
When applied on top of apache#12198, this reduces the time to index geonames with 20
threads from ~19s to ~16-17s.
    @jpountz
    jpountz committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    482fc3c View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. Simplify a bit and add more comments about the workings of this pool.

    @jpountz
    jpountz committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    be8b8b8 View commit details
    Browse the repository at this point in the history

  2. Better style, approved by the policeman.

    @jpountz
    jpountz committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    92a9fcb View commit details
    Browse the repository at this point in the history

  3. More tests.

    @jpountz
    jpountz committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    a560270 View commit details
    Browse the repository at this point in the history

  4. tidy

    @jpountz
    jpountz committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    c853888 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Merge branch 'main' into reduced_contention_dwpt_pool

    @jpountz
    jpountz committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    8418029 View commit details
    Browse the repository at this point in the history

  2. CHANGES

    @jpountz
    jpountz committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    3fdd42b View commit details
    Browse the repository at this point in the history

  3. Extract lock to local variable.

    @jpountz
    jpountz committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    6461538 View commit details
    Browse the repository at this point in the history

  4. Check if assertions are enabled.

    @jpountz
    jpountz committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    ec760be View commit details
    Browse the repository at this point in the history