Remove usage and add some legacy java.util classes to forbiddenapis (Stack, Hashtable, Vector) #12404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Hashtable, Vector)
uschindler
changed the title
mkhludnev
approved these changes
Jun 29, 2023
asfgit
pushed a commit
that referenced
this pull request
Jun 29, 2023
…Stack, Hashtable, Vector) (#12404) # Conflicts: # lucene/facet/src/java/org/apache/lucene/facet/sortedset/DefaultSortedSetDocValuesReaderState.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed on some other PR that some classes (especially
java.util.Stack) are used in Lucene code although they are really legacy from Java 1.0. The problem with them is that they are synchronized. Stack is used in some preformance critical code.This PR adds them to forbiddenapis and fixes usage.
There is a small problem with forbiddenapis, that it triggers on Hashtable for declarations of
java.util.Properties(as this one extends fromHashtableas implementation detail. For now I commented the forbidden rule.