Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hunspell: simplify TrigramAutomaton to speed up the suggestion enumeration #12491

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

donnerpeter
Copy link
Contributor

avoid the automaton access on definitely absent characters; count the scores for all substring lengths together

…ation

avoid the automaton access on definitely absent characters;
count the scores for all substring lengths together
@donnerpeter donnerpeter requested a review from dweiss August 5, 2023 20:27
@donnerpeter
Copy link
Contributor Author

This gives ~10% speed improvement on German, Russian and Ukrainian suggestions

Copy link
Contributor

@dweiss dweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry on the delay, on vacation.

@donnerpeter donnerpeter merged commit 13e747f into apache:main Aug 8, 2023
5 checks passed
@donnerpeter donnerpeter deleted the peter/singleScoreMaxChar branch September 12, 2023 09:33
donnerpeter added a commit that referenced this pull request Sep 12, 2023
…ation (#12491)

* hunspell: simplify TrigramAutomaton to speed up the suggestion enumeration

avoid the automaton access on definitely absent characters;
count the scores for all substring lengths together

(cherry picked from commit 13e747f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants