Ensure DrillSidewaysScorer calls LeafCollector#finish on all sideways-dim FacetsCollectors #12640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slow-J
reviewed
Nov 10, 2023
Comment on lines
+149
to
+151
| // System.out.println("queryFirst: baseScorer=" + baseScorer + " disis.length=" + | ||
| // disis.length | ||
| // + " bits.length=" + bits.length); |
There was a problem hiding this comment.
Suggested change
| // System.out.println("queryFirst: baseScorer=" + baseScorer + " disis.length=" + | |
| // disis.length | |
| // + " bits.length=" + bits.length); | |
| // System.out.println("queryFirst: baseScorer=" + baseScorer + " disis.length=" | |
| // + disis.length + " bits.length=" + bits.length); |
|
LGTM, I think that this requires a rebase after https://github.com/apache/lucene/pull/12642/files |
…-dim FacetsCollectors We need to be defensive against CollectionTerminatedException and make sure we still #finish all collectors.
gsmiller
force-pushed
the
GH/ds-finish-on-early-terminate
branch
from
b8a6cd8
to
dcc2403
Compare
gsmiller
added a commit
that referenced
this pull request
Nov 14, 2023
…-dim FacetsCollectors (#12640)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As DrillSidewaysScorer is currently written, if any leaf collectors throw CollectionTerminatedException then
LeafCollector#finishwon't properly get called. This patch makes sure we always call#finish.