Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging for vector support #12676

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

uschindler
Copy link
Contributor

This improves logging a bit:

  • if java version is too old, but user explicitely enabled the incubator module
  • inform user about missing integer support

Robert and I hit this when tetsing the benchmark.

…duel enabled; inform user about missing integer support
@uschindler uschindler added this to the 9.9.0 milestone Oct 13, 2023
@uschindler uschindler self-assigned this Oct 13, 2023
Copy link
Member

@rmuir rmuir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, i was scratching my head about confusing logging output (actually lack thereof) from the benchmark, but i was using java 17...

I also like the message when vectors are only "half-enabled"!

@uschindler uschindler merged commit 2b8c4b0 into apache:main Oct 13, 2023
4 checks passed
asfgit pushed a commit that referenced this pull request Oct 13, 2023
Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants