move Operations.sameLanguage/subsetOf to AutomatonTestUtil in test-framework #13708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dweiss
approved these changes
Sep 3, 2024
| @@ -35,9 +35,14 @@ | |||
| * @lucene.experimental | |||
| */ | |||
| public class StatePair { | |||
| // only mike knows what it does (do not expose) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods run in quadratic time and have been traps in the past: they run in quadratic time.
I think originally this was
equals()but it is so costly, that we factored out into separatesameLanguagemethods.Additionally methods are a bit smelly, they will throw exception if the inputs aren't deterministic, and they'll only
assertif there are transitions to dead states... they are really only suitable for tests code.We've been making progress moving some of this code to test framework, this is just the next iteration. Would love to factor out more (dead states checks etc) but that's more difficult.