Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUCENE-9204: Remove Spans references from DisiWrapper #150

Merged
merged 3 commits into from
May 25, 2021

Conversation

romseygeek
Copy link
Contributor

We have a number of helper classes in o.a.l.search that aid the
implementation of two-phase iteration over disjunctions. These have
some Spans-specific code, which will stop compiling once Spans
are moved into the queries module. This commit removes the
Spans references from the main code and duplicates the helper
code within the Spans package.

@romseygeek romseygeek self-assigned this May 25, 2021
@romseygeek
Copy link
Contributor Author

I had hoped to do something similar to what we did for ConjunctionUtils and pull things into shared public factory classes, but that ended up with some very nasty generics code (things like DisiWrapper<T extends DisiWrapper>) so I think just cloning the classes here is unfortunately the correct tradeoff to make.

Copy link
Member

@mikemccand mikemccand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome -- it's great to strongly separate spans from disjunctions support classes.

@romseygeek romseygeek merged commit 4b55ae5 into apache:main May 25, 2021
@romseygeek
Copy link
Contributor Author

Thanks for the reviews @mikemccand!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants