LUCENE-10236: Add change entry #456
Conversation
lucene/CHANGES.txt
Outdated
| @@ -57,7 +57,9 @@ Optimizations | |||
|
|
|||
| Bug Fixes | |||
| --------------------- | |||
| (No changes) | |||
|
|
|||
| * LUCENE-10236: Update field-weight used in CombinedFieldQuery scoring calculation. | |||
There was a problem hiding this comment.
Maybe say a bit more about what really changed than just "update", e.g. stop duplicating norms and term frequencies when scoring in CombinedFieldQuery?
There was a problem hiding this comment.
Ah sorry. I've updated it accordingly.
There was a problem hiding this comment.
Hi @mikemccand , just want to check back on this to see if the updated entry looks good to you?
There was a problem hiding this comment.
Oh yes looks great sorry for the slow response!
There was a problem hiding this comment.
No problem, thanks @mikemccand for the review and approval!
|
Hmm actually this issue was fixed in 9.0.0, I think? |
This change entry is for 07ee3ba#diff-27a1984493254d0af3e9c50caee47443abbbdc79a87b4c348300bcb317a0a5b2, as I forgot to add it in that merge. I checked the commit immediately after mine ad911df on On the other hand, Not sure if I may miss something? |
Hi @mikemccand , just want to check back on this and see if you have any further concern? |
|
Aha, perfect, looks great! +1 to push. Sorry for the delay @zacharymorn. |
No problem! Thanks for the review and approval! |
No description provided.