LUCENE-9877: Allow up to 7 exceptions in PForUtil (instead of 3) #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change allows PForUtil to encode up to 7 exceptions per encoded block (instead of the 3 allowed today) in order to reduce index size.
Solution
I tested the impact of 7 exceptions vs. 3 using a new tool I wrote to directly inspect the contents of PFOR encoded index blocks (details in the Jira) as well as inspected overall index size reduction. I also tested QPS impact using luceneutil benchmark tools. All details are in the Jira issue.
Note that this change should be fully backwards compatible, even though I don't think that needs to be a requirement. Details of this are also mentioned in the Jira issue.
Tests
All existing tests pass. No new tests seemed necessary as TestPForUtil already exercises the code.
Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.