LUCENE-9902 Minor fixes to the faceting API

[gautamworah96]

Changes:

1. Update getOrdinal(String, String[]) call to getOrdinal(String,
   String...)
2. Update getValue(int) API to be protected

Description

I was using the public int getOrdinal(String dim, String[] path) API for a single path String and found myself creating an array with a single element. We can start using variable length args for this method.

I also propose this change:
I wanted to know the specific count of an ordinal using using the getValue API from IntTaxonomyFacets but the method is private. It would be good if we could change it to protected so that users can know the value of an ordinal without looking up the FacetLabel and then checking its value.

Solution

Changed the function definition and access modifier.
Checked that no other method used the String[] parameter. Also checked that other methods that deal with ordinals and values in IntTaxonomyFacets are also protected

Tests

Already existing tests cover these methods.

Checklist

Please review the following and check all that apply:

• I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
• I have created a Jira issue and added the issue ID to my pull request title.
• I have given Lucene maintainers access to contribute to my PR branch. (optional but recommended)
• I have developed this patch against the main branch.
• I have run ./gradlew check.
• I have added tests for my changes.

[mikemccand]

Looks great and makes sense! Thank you for your attention to these details @gautamworah96.

Could you maybe add a CHANGES.txt entry, under the Lucene 8.9.0 section?

[mikemccand]

Thanks @gautamworah96