Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUCENE-10575: Fix some visibility issues #894

Merged
merged 2 commits into from
May 16, 2022

Conversation

romseygeek
Copy link
Contributor

  • ExternalRefSorter.ByteSequenceIterator should be public, as it's designed for external use
  • MatchRegionRetriever refers to a private class in its public javadoc. I've just removed the link for now, but we could think about making the private implementation public as it looks as though it may be useful for other implementations of the highlighter?
  • STMergingTermsEnum is now package-private. It uses private classes in some protected methods, and just making the whole thing package-private seemed to be the simplest solution to me. If we want to keep it public, then we should probably go through this more carefully and work out what needs to be available for extension and what doesn't.

@romseygeek romseygeek requested review from dweiss and dsmiley May 16, 2022 11:40
@romseygeek romseygeek self-assigned this May 16, 2022
Copy link
Contributor

@dweiss dweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@romseygeek romseygeek merged commit 8921b23 into apache:main May 16, 2022
@romseygeek
Copy link
Contributor Author

Thanks both!

asfgit pushed a commit that referenced this pull request May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants