Handle more cases in BooleanWeight#count.
#961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested by @zhaih on apache#950, we could support more cases in `BooleanWeight#count`. This PR adds support for these cases specifically: - Pure disjunctions where only one clause has a non-zero count. - Pure disjunctions where one clause matches all docs. - Negations where positive clauses match all docs (pure negation). - Negations where positive clauses match no docs. - Negations where negative clauses match no docs. - Negations where negative clauses match all docs.
zhaih
approved these changes
Jun 16, 2022
| } | ||
|
|
||
| /** | ||
| * Return the number of matches of required clauses, or -1 if unknown, or 0 if there are no |
There was a problem hiding this comment.
number of matches of optional (instead of "required") clauses?
| } else if (query.getClauses(Occur.FILTER).isEmpty() == false | ||
| || query.getClauses(Occur.MUST).isEmpty() == false) { | ||
| if (query.getMinimumNumberShouldMatch() > 0) { | ||
| positiveCount = -1; |
There was a problem hiding this comment.
There'll be still some rare cases here? When minShouldMatch > 0 and no should clause match; when minShouldMatch == 1 and should clauses matches all?
|
Thanks for the review, I pushed a comment to clarify that more cases could be handled. |
jpountz
added a commit
that referenced
this pull request
Jun 21, 2022
As suggested by @zhaih on #950, we could support more cases in `BooleanWeight#count`. This PR adds support for these cases specifically: - Pure disjunctions where only one clause has a non-zero count. - Pure disjunctions where one clause matches all docs. - Negations where positive clauses match all docs (pure negation). - Negations where positive clauses match no docs. - Negations where negative clauses match no docs. - Negations where negative clauses match all docs.
shaie
pushed a commit
to mdmarshmallow/lucene
that referenced
this pull request
Jun 22, 2022
As suggested by @zhaih on apache#950, we could support more cases in `BooleanWeight#count`. This PR adds support for these cases specifically: - Pure disjunctions where only one clause has a non-zero count. - Pure disjunctions where one clause matches all docs. - Negations where positive clauses match all docs (pure negation). - Negations where positive clauses match no docs. - Negations where negative clauses match no docs. - Negations where negative clauses match all docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @zhaih on #950, we could support more cases in
BooleanWeight#count. This PR adds support for these cases specifically: