Web Connector: Fix SSL issues in redirections #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 15, 2024 15:05
Ignore SLL verification when getting final URL in case of redirects
|
Thank you @Soggard for your contribution, we will consider this for ManifoldCF 2.28 because we don't want to apply any changes to the base code for 2.27 release, this due to the drastic change in the release process. I have just created another ticket for this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that in some case, when using the new "Force the inclusion of redirections" option in the Web Crawler Connector, we encounter SSL certificate error. This happens when whe try to get the final URL from a redirection in order to add it to the seed.
We can fix this by disabling SSL verification while getting final URL from pages with redirections. The unchecked certificates should not cause any problems, since it's only about adding the new host to the seed. All usual checks will be applied during the indexing.
Note that when fetching the final url, we do not take into account the connector's graphical option to able or disable certificate validation: certificates are always ignored. Still, once the actual crawling takes place when the final list of seed hosts is established, the option about certification validation is respected again.