Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MARCHETYPES-76] maven-archetype-quickstart generates EOLed maven.compiler setup #25

Merged

Conversation

judovana
Copy link
Contributor

@judovana judovana commented Dec 25, 2023

if the #24 will be merged, the [MARCHETYPES-76] will be fixed too, however the
1.8 bump test for maven-archetype-quickstart will lost sesne/

The test should be changed from bump 1.7 -> 1.8 to downgrade 1.8 to 1.7, so the action is of "change the jdk" will persist. and - as bumps to modular jdks are there, change to non-modular jdk should remain here, as there is "if" in macros to modular/non modular jdk, so even once default jdk will be modular, the downgrade to non modular jdk should remain here

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MARCHETYPES-XXX] SUMMARY, where you replace MARCHETYPES-XXX
    and SUMMARY with the appropriate JIRA issue. Best practice is to use the JIRA issue
    title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@judovana
Copy link
Contributor Author

judovana commented Jan 2, 2024

Note, that the CI on this is, and will be failing, untill #24 is merged. I have no issues to add this into #24 itself, but @slachiewicz required to have this test change in separate PR.

Note, that without #24 the change do not have any reasoning.

@judovana judovana force-pushed the maven-archetype-quickstart-tests-after-jdk8 branch from 3ef750a to 39bc8c0 Compare January 2, 2024 16:35
@judovana
Copy link
Contributor Author

judovana commented Jan 2, 2024

I had rebased it so it is not based on #23, as it do not need to be.
I is still depending on #24 anyway (aka have no reasoning without it)

@elharo elharo merged commit a0f0e9a into apache:master Jan 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants