Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests with Java 8 and 21 #23

Closed
wants to merge 1 commit into from
Closed

Add tests with Java 8 and 21 #23

wants to merge 1 commit into from

Conversation

judovana
Copy link
Contributor

Originally by @slachiewicz

Based on the "discussions" in:
https://lists.apache.org/thread/chqcxvlko3nz6cgrs2kzjrdy5tv9spkx , #22 , #20 , #18

the base commit ensuring the tests run on all live LTS javas

@judovana
Copy link
Contributor Author

judovana commented Dec 25, 2023 •
edited
Loading

This is base commit for #24 and should be merged first. If not approved, it should be rebased

@judovana judovana mentioned this pull request Dec 25, 2023
Merged
6 tasks
elharo
elharo requested changes Jan 2, 2024
View reviewed changes
Copy link

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failing. Not immediately obvious to me why:

[INFO] [INFO] ------------------------------------------------------------------------
Error: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-archetype-plugin:3.2.0:integration-test (default-integration-test) on project basic-archetype:
Error: [ERROR] Archetype IT 'it-basic' failed: Execution failure: exit code = 1
Error: [ERROR] -> [Help 1]
[INFO] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-archetype-plugin:3.2.0:integration-test (default-integration-test) on project basic-archetype:
[INFO] Archetype IT 'it-basic' failed: Execution failure: exit code = 1
[INFO] at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:333)
[INFO] at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316)
[INFO] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212)
[INFO] at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174)

@judovana
Copy link
Contributor Author

judovana commented Jan 2, 2024

hi!

Sorry, I had to be explicit in initial comment - this is expected to fail, because jdk21 is not supported.
If you look into #24, which is adding jdk21 support, and which is based on this PR's commit, you will see the tests are passing

@judovana
Copy link
Contributor Author

judovana commented Jan 2, 2024 •
edited
Loading

The changes were split to several PRs on @slachiewicz request (or at least that is as I parsed that)

@judovana judovana mentioned this pull request Jan 2, 2024
Merged
6 tasks
elharo
elharo reviewed Jan 2, 2024
View reviewed changes
Copy link

@elharo elharo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so should this PR be closed or rebased against master now that #24 has been merged?

@judovana
Copy link
Contributor Author

judovana commented Jan 3, 2024

This is present in: 65fe5ee#diff-0d8d63e58484b917cba33e4838a95e7433ee11fd7d9845b16bee9cf807a8de54 and was merged as part of the #24 thus closing. TYVM!

@judovana judovana closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elharo elharo elharo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@judovana @elharo