Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MARCHETYPES-78] Update default Java version in archetype projects to 1.8 #24

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

judovana
Copy link
Contributor

Based on "discussion"

Based on the "discussions" in:
https://lists.apache.org/thread/chqcxvlko3nz6cgrs2kzjrdy5tv9spkx , #22 , #20 , #18

bumping default jdk of all archetype projects to 1.8.
This expects #23 to be emrged first. ig n ot, it shoudl be rebased.
Note that the test in maven-archetype-quickstart now do not have sense. As there was not a agreement that the test shuold be changed, it will be done in separate PR

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MARCHETYPES-XXX] SUMMARY, where you replace MARCHETYPES-XXX
    and SUMMARY with the appropriate JIRA issue. Best practice is to use the JIRA issue
    title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@elharo elharo merged commit 65fe5ee into apache:master Jan 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants