Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBUILDCACHE-81] - Add an option to include project version as part of the cache hash key #129

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

igdianov
Copy link
Contributor

@igdianov igdianov commented Jan 29, 2024

Fixes https://issues.apache.org/jira/projects/MBUILDCACHE/issues/MBUILDCACHE-81

  • Add new calculateProjectVersionChecksum attribute to project versioning cache configuration to enable/disable calculation of the project version checksum input. The default is false to maintain original behavior for cache portability between versions.
  • Add/update unit and integration tests to cover possible use cases.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a MBUILDCACHE JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MBUILDCACHE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MBUILDCACHE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@olamy olamy added the bug Something isn't working label Jan 30, 2024
@igdianov igdianov changed the title [MBUILDCACHE-81] - Fix Cache portability between project versions is broken due to [MBUILDCACHE-76] [MBUILDCACHE-81] - Fixes cache portability between project versions is broken due to [MBUILDCACHE-76] Jan 30, 2024
@olamy
Copy link
Member

olamy commented Feb 1, 2024

I would suggest to change the title of the PR and the jira as well.
As MBUILDCACHE-76 has not been released but merged only, the release notes will be very confusing as is :)
maybe something saying add an option to add add project version as part of the cache hash key.
wdyt?

@igdianov igdianov changed the title [MBUILDCACHE-81] - Fixes cache portability between project versions is broken due to [MBUILDCACHE-76] [MBUILDCACHE-81] - Add an option to include project version as part of the cache hash key Feb 2, 2024
@igdianov
Copy link
Contributor Author

igdianov commented Feb 2, 2024

I would suggest to change the title of the PR and the jira as well. As MBUILDCACHE-76 has not been released but merged only, the release notes will be very confusing as is :) maybe something saying add an option to add add project version as part of the cache hash key. wdyt?

It makes sense. I updated PR and Jira ticket titles.

@olamy olamy merged commit 8980885 into apache:master Feb 2, 2024
26 checks passed
@igdianov igdianov deleted the fix-MBUILDCACHE-76 branch February 4, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants