Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add / Improve tests for tree goal #29

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mthmulders
Copy link
Contributor

The Tree goal lacks decent tests. This makes it hard to add new features without breaking stuff (see e.g. the discussion in #24). I decided to re-write tests for this goal by mocking away the components that the Tree goal uses.

The work is far from done. That's why there's no JIRA issue yet, and I deliberately did not check any of the licensing checkbox at the end of the checklist. Rather, I'd have a discussion whether this is the right approach for testing the goal. If so, I can continue the work in this direction. If all is done, we can do the administration (JIRA, agreement of Apache License, etc.).

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MDEP-XXX] - Fixes bug in ApproximateQuantiles, where you replace MDEP-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

Copy link

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this.

Using mocks is good as it is really lightweight.

To me the approach is okay, but I have never worked on this module.

It would be useful to see the opinion of experts of this plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants