Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Tree goal lacks decent tests. This makes it hard to add new features without breaking stuff (see e.g. the discussion in #24). I decided to re-write tests for this goal by mocking away the components that the Tree goal uses.
The work is far from done. That's why there's no JIRA issue yet, and I deliberately did not check any of the licensing checkbox at the end of the checklist. Rather, I'd have a discussion whether this is the right approach for testing the goal. If so, I can continue the work in this direction. If all is done, we can do the administration (JIRA, agreement of Apache License, etc.).
[MDEP-XXX] - Fixes bug in ApproximateQuantiles
, where you replaceMDEP-XXX
with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.mvn clean verify
to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.mvn -Prun-its clean verify
).If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.