Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOXIASITETOOLS-324] Allow configuration of parsers #140

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

kwin
Copy link
Member

@kwin kwin commented Mar 20, 2024

Introduce interface ParserConfigurator which can be passed to SiteRenderingContext

@kwin
Copy link
Member Author

kwin commented Mar 20, 2024

This is the leaner alternative to #126

@kwin kwin force-pushed the feature/configure-with-plexus-configurator branch 2 times, most recently from adc2018 to b086a5f Compare March 27, 2024 07:28
@kwin kwin marked this pull request as ready for review March 27, 2024 07:28
@michael-o michael-o force-pushed the feature/configure-with-plexus-configurator branch from b086a5f to 9a8bc62 Compare April 19, 2024 17:28
@michael-o michael-o self-requested a review April 19, 2024 17:29
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will go over to Maven Site Plugin PR.

public interface ParserConfigurator {

/**
* Configures the given parser, which is afterwards used to parse the source file with the given path.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parser which

Introduce interface ParserConfigurator which can be passed to
SiteRenderingContext
@kwin kwin force-pushed the feature/configure-with-plexus-configurator branch from 9a8bc62 to 39b79bb Compare April 20, 2024 17:42
@kwin kwin merged commit 2cdd1de into master Apr 20, 2024
34 checks passed
@kwin kwin deleted the feature/configure-with-plexus-configurator branch April 20, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants