[MINVOKER-250] streamLogsOnFailures

[slawekjaranowski]

No description provided.

[elharo]

Is xml.attribute something modello has already defined? They shouldn't have. Names beginning xml are reserved in the XML 1.0 spec.

[slawekjaranowski]

Another fields in this file is defined in the same way.

As I see xml.attribute="true" has effect that field is added as xml attribute instead of new element/tag in xml.

[slawekjaranowski]

http://maven.apache.org/plugins/maven-invoker-plugin/build-job.html

[slawekjaranowski]

PR was rebased with current master branch.
Code was corrected according to comments from review.

[elharo]

I might try to shorten the name of the option. E.g. instead of streamLogsOnFailures perhaps simply logFailures

[slawekjaranowski]

I wanted to name this option similar to one existing streamLogs.
I think that we will also change connected jira issue, so we should be consistent .

I'm waiting for decision.

[elharo]

It occurred to me last night that since this is a user facing property, there are likely some docs that need to be updated in this PR as well. A property doesn't help if no one can find it.

[slawekjaranowski]

Which document do you think should be updated?

I added javadocs comments on new option, so it will be available on standard mojo help, on site and by command line.

[elharo]

Wherever we document config options on https://maven.apache.org/plugins/maven-invoker-plugin/

…

On Tue, May 19, 2020 at 11:23 AM Slawomir Jaranowski < ***@***.***> wrote: Which document do you think should be updated? I added javadocs comments on new option, so it will be available on standard mojo help, on site and by command line. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#20 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHVP2DFCEC6WBB7GOPBUW3RSKP5HANCNFSM4LVRGQSA> .

-- Elliotte Rusty Harold elharo@macfaq.com

[olamy]

@slawekjaranowski Thanks for this PR this new feature will be very helpful!! Maybe you can can add a page in examples section something very simple similar to https://maven.apache.org/plugins/maven-invoker-plugin/examples/skipping.html

[slawekjaranowski]

Documentation added in exemples.