-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MJLINK-83] Implement multiple launcher elements #202
Conversation
I do support this feature that is useful |
sounds good. Could you please add a simple test for this new feature? |
I have added a new test class as requested @olamy |
Thanks. I would prefer avoid using the technique of reflection and prefer using something such https://github.com/apache/maven-compiler-plugin/blob/master/src/test/java/org/apache/maven/plugin/compiler/CompilerMojoTestCase.java |
I will look into that. I based the first attempt on the existing test |
good point. Another technique is available here https://github.com/apache/maven-invoker-plugin/blob/1bd7bb2d009b40d747fad3808458d984c4abde21/src/test/java/org/apache/maven/plugins/invoker/InvokerMojoTest.java#L50 |
I've been able to do it using your second suggested method, i.e. using The calls now look like this:
What do you think? I just couldn't get the first method, using the |
Yup sorry I realised I sent a link on plugins now build with Maven 4. |
978eb25
to
2771efd
Compare
OK if I understand correctly we're going back to reflection because Also I fixed a warning from Is that everything? |
This is a simple change to allow the Maven plugin to generate more than one launcher in a
jlink
image. Thejlink
tool itself already supports this, but there was no way to pass the required invocation onto it from Maven.Following this checklist to help us incorporate your
contribution quickly and easily:
[MJLINK-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MJLINK-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.