Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the doc text of mvnd.pluginRealmEvictPattern option #533

Closed
ppalaga opened this issue Dec 14, 2021 · 1 comment
Closed

Improve the doc text of mvnd.pluginRealmEvictPattern option #533

ppalaga opened this issue Dec 14, 2021 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Dec 14, 2021

From the current text https://github.com/mvndaemon/mvnd/blob/4bb5c5d5b533938d7710eeb08ac1aff5800e29d5/common/src/main/java/org/mvndaemon/mvnd/common/Environment.java#L253-L256 it is not clear how to use the option. An example would help. The option says it is a regexp, but based on gnodet@9ed8647#diff-e65744bdec30df4a8c9692d35f97c28fef1e81af93a54a3d0dbf5f0a8e8abd88R246 it seems to be that glob is the default.
@ppalaga ppalaga added the documentation Improvements or additions to documentation label Dec 14, 2021
@ppalaga ppalaga mentioned this issue Dec 14, 2021
Closed
3 tasks
gnodet added a commit to gnodet/mvnd that referenced this issue Dec 15, 2021
@gnodet
Improve the doc text of mvnd.pluginRealmEvictPattern option, fixes ap…
91ef6cc 
…ache#533
@gnodet
Copy link
Contributor

gnodet commented Dec 15, 2021

@ppalaga let me know if the doc seems understandable enough or if I should add more.

@gnodet gnodet closed this as completed in 09cb99f Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gnodet @ppalaga