Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warning about JAnsi Terminal #1017

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Fix deprecation warning about JAnsi Terminal #1017

merged 2 commits into from
Jun 13, 2024

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Jun 13, 2024 •
edited
Loading

And use JNI (and FFM) instead.

Changes:

  • use DefaultClient from master (thanks @gnodet !)
  • drop jansi (as DefaultClient should not depend on it)
  • introduce two new jline3 terminal backends: jni and ffm (used on Java 22+)
  • tested/verified (thanks @wendigo )

@cstamas
Fix deprecation warning about JAnsi Terminal
114547f 
And use JNI (and FFM) instead.
@cstamas cstamas requested a review from gnodet June 13, 2024 18:48
@cstamas cstamas self-assigned this Jun 13, 2024
wendigo
wendigo approved these changes Jun 13, 2024
View reviewed changes
Copy link

@wendigo wendigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wendigo
Copy link

wendigo commented Jun 13, 2024

Thanks for fixing this :)

@cstamas cstamas merged commit f32d000 into apache:mvnd-1.x Jun 13, 2024
5 checks passed
@cstamas cstamas deleted the mvnd-1.x-fix-jansi-dep branch June 13, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wendigo wendigo wendigo approved these changes

@gnodet gnodet gnodet approved these changes

Assignees

@cstamas cstamas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cstamas @wendigo @gnodet