Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade SLF4J to version 1.7.35 #591

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Conversation

oscerd
Copy link
Contributor

@oscerd oscerd commented Jan 21, 2022

2022-01-13 - Release of SLF4J 1.7.33

• SLF4J now ships with the slf4j-reload4j module delegating to the reload4j backend. Reload4j is a drop-in replacement for log4j version 1.2.17.

• SimpleLogger now prints the thread Id if instructed to do so. This fixes SLF4J-499 requested by Michael Osipov

@gnodet
Copy link
Contributor

gnodet commented Jan 21, 2022

2022-01-13 - Release of SLF4J 1.7.33

• SLF4J now ships with the slf4j-reload4j module delegating to the reload4j backend. Reload4j is a drop-in replacement for log4j version 1.2.17.

• SimpleLogger now prints the thread Id if instructed to do so. This fixes SLF4J-499 requested by Michael Osipov

FTR, I don't think mvnd is impacted by those two issues as the backend used is logback.

Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2022-01-13 - Release of SLF4J 1.7.33
• SLF4J now ships with the slf4j-reload4j module delegating to the reload4j backend. Reload4j is a drop-in replacement for log4j version 1.2.17.
• SimpleLogger now prints the thread Id if instructed to do so. This fixes SLF4J-499 requested by Michael Osipov

FTR, I don't think mvnd is impacted by those two issues as the backend used is logback.

Yes, we have not used log4j 1.x, but we do use slf4j-simple in the client.

Thanks the PR @oscerd

@gnodet
Copy link
Contributor

gnodet commented Jan 21, 2022

FTR, I don't think mvnd is impacted by those two issues as the backend used is logback.

Yes, we have not used log4j 1.x, but we do use slf4j-simple in the client.

Right, I forgot about that. That makes we wonder if the following file is used at all:
https://github.com/apache/maven-mvnd/blob/79137867e51e04e24ae1e924afbd2e4f77e2d860/dist/src/main/distro/conf/logback-client.xml

@ppalaga
Copy link
Contributor

ppalaga commented Jan 21, 2022

makes we wonder if the following file is used at all:
https://github.com/apache/maven-mvnd/blob/79137867e51e04e24ae1e924afbd2e4f77e2d860/dist/src/main/distro/conf/logback-client.xml

Yes, it is probably a left-over from earlier times when we used or wanted to use logback on the client.

@gnodet gnodet changed the title Upgrade SLF4J to version 1.7.33 Upgrade SLF4J to version 1.7.35 Jan 31, 2022
@gnodet gnodet added this to the 0.7.2 milestone Jan 31, 2022
@gnodet gnodet self-assigned this Jan 31, 2022
@gnodet gnodet merged commit 087a6d7 into apache:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants